Conversation
Adds full CRUD support for the Weaviate namespaces feature (requires Weaviate 1.38.0+): create/get/list/delete namespace endpoints, RBAC manage_namespaces permission, namespace-scoped DB user creation, and UserDB.namespace field. Includes unit and integration test suites with a dedicated docker-compose fixture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
- Add namespaces_permissions=[] to all Role(...) constructions in integration/test_rbac.py to match the new required dataclass field - Wait for namespaces port (8094) in ci/compose.sh - Use _decode_json_response_list helper in namespaces.list_all - Round-trip via roles.get(...) in namespace permission integration tests - Use pass instead of return None in delete callback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@copilot review |
Agent-Logs-Url: https://github.com/weaviate/weaviate-python-client/sessions/35eb3c0e-1e3a-4ae7-bde7-6c6c481dbe5a Co-authored-by: jfrancoa <23482278+jfrancoa@users.noreply.github.com>
Here's a summary of the review findings and fixes applied: CI Failure (already fixed in Additional fix ( All 12 unit tests pass, and both Code Review and CodeQL Security scans are clean. |
When a global user (operator) passes a namespaced collection name of the form "namespace:CollectionName" (required on namespace-enabled clusters), only the collection portion after the colon should be capitalized. The namespace prefix must stay lowercase as it follows [a-z][a-z0-9]*. This single-point fix covers all 30+ call sites that use _capitalize_first_letter, including collections.delete/get/exists, batch operations, RBAC permissions, backup/export, and filters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.38 #2033 +/- ##
===========================================
Coverage ? 86.71%
===========================================
Files ? 307
Lines ? 23241
Branches ? 0
===========================================
Hits ? 20153
Misses ? 3088
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds 15 mock-based tests in mock_tests/test_namespaces.py covering the
HTTP contract for the new module without requiring a Weaviate cluster.
Brings weaviate/namespaces/base.py from 33% to 100% coverage and exercises
the new code paths in weaviate/users/base.py (namespace request body and
UserDB.namespace response field).
Notable cases that catch real regressions:
- 404 on get -> None (guards ok_in=[200, 404])
- list_all on null/empty body -> [] (guards the "or []" fallback)
- Every public method asserts the 1.38.0 version guard (catches future
contributors lowering the minimum or adding a method without the guard)
- POST /v1/users/db/{id} body shape with and without namespace
- UserDB.namespace populated from server response and defaulting to None
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Summary
client.namespaceswith full CRUD:create,get,list_all,delete(requires Weaviate 1.38.0+)Permissions.namespaces(namespace=..., manage=True)RBAC factory andNamespacesAction.MANAGEenum, wired intoRoleparsingclient.users.db.create(user_id=..., namespace=...)to bind a DB user to a namespace;UserDB.namespacefield populated from server responsesci/docker-compose-namespaces.ymlfor integration test fixtures (ports 8094/50064, RBAC + dynamic DB users +NAMESPACES_ENABLED=true)test/test_namespaces.py) and 7 integration tests (integration/test_namespaces.py), all passingTest plan
pytest test/test_namespaces.py— 12 unit tests (no server required)WEAVIATE_VERSION=1.38.x docker compose -f ci/docker-compose-namespaces.yml up -dpytest integration/test_namespaces.py— 7 integration tests covering create/get/list/delete namespace, namespaced user creation, and RBAC permission management🤖 Generated with Claude Code